Migrate instrumentations to Context API #9358

PerfectSlayer · 2025-08-13T07:39:31Z

What Does This Do

Migrate HttpServerDecorator.onRequest() to the Context API.

In particular, get rid of the duplicate version using AgentSpan.Extracted instead.
This lead to overridden decorators no longer being called when moved to the Context based version -- unclear how tests did not catch it.

Motivation

Move instrumentation API to the Context API to decouple products and move toward better performance.

Additional Notes

Follow up PR of #9211

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: LANGPLAT-680

datadog-official · 2025-08-13T08:12:28Z

Code coverage: total 57.34%, base diff -0.00%, patch 80.77% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 364cab5 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-13T08:23:28Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context
git_commit_date	1755272433	1755367363
git_commit_sha	`f15598a`	`364cab5`
release_version	1.53.0-SNAPSHOT~f15598ae39	1.53.0-SNAPSHOT~364cab503d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755369193	1755369193
ci_job_id	1083318937	1083318937
ci_pipeline_id	73877290	73877290
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-0ietnxs9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-0ietnxs9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~364cab503d, baseline=1.53.0-SNAPSHOT~f15598ae39

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043804
Total [baseline] (8.612 s) : 0, 8611931
Agent [candidate] (1.045 s) : 0, 1044628
Total [candidate] (8.579 s) : 0, 8578564
section iast
Agent [baseline] (1.176 s) : 0, 1176328
Total [baseline] (9.325 s) : 0, 9324512
Agent [candidate] (1.173 s) : 0, 1173327
Total [candidate] (9.329 s) : 0, 9329428

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	iast	1.176 s	132.524 ms (12.7%)
Total	tracing	8.612 s	-
Total	iast	9.325 s	712.581 ms (8.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.045 s	-
Agent	iast	1.173 s	128.698 ms (12.3%)
Total	tracing	8.579 s	-
Total	iast	9.329 s	750.864 ms (8.8%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~364cab503d, baseline=1.53.0-SNAPSHOT~f15598ae39

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (731.358 ms) : 0, 731358
BytebuddyAgent [candidate] (730.157 ms) : 0, 730157
GlobalTracer [baseline] (241.772 ms) : 0, 241772
GlobalTracer [candidate] (241.529 ms) : 0, 241529
AppSec [baseline] (30.147 ms) : 0, 30147
AppSec [candidate] (30.383 ms) : 0, 30383
Debugger [baseline] (6.017 ms) : 0, 6017
Debugger [candidate] (6.041 ms) : 0, 6041
Remote Config [baseline] (650.053 µs) : 0, 650
Remote Config [candidate] (652.046 µs) : 0, 652
Telemetry [baseline] (11.44 ms) : 0, 11440
Telemetry [candidate] (13.54 ms) : 0, 13540
section iast
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.411 ms) : 0, 1411
BytebuddyAgent [baseline] (849.182 ms) : 0, 849182
BytebuddyAgent [candidate] (847.82 ms) : 0, 847820
GlobalTracer [baseline] (232.43 ms) : 0, 232430
GlobalTracer [candidate] (231.587 ms) : 0, 231587
AppSec [baseline] (28.37 ms) : 0, 28370
AppSec [candidate] (26.512 ms) : 0, 26512
Debugger [baseline] (7.606 ms) : 0, 7606
Debugger [candidate] (5.701 ms) : 0, 5701
Remote Config [baseline] (583.725 µs) : 0, 584
Remote Config [candidate] (584.511 µs) : 0, 585
Telemetry [baseline] (9.036 ms) : 0, 9036
Telemetry [candidate] (8.253 ms) : 0, 8253
IAST [baseline] (26.796 ms) : 0, 26796
IAST [candidate] (30.637 ms) : 0, 30637

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~364cab503d, baseline=1.53.0-SNAPSHOT~f15598ae39

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042782
Total [baseline] (10.718 s) : 0, 10717880
Agent [candidate] (1.048 s) : 0, 1048011
Total [candidate] (10.745 s) : 0, 10745408
section appsec
Agent [baseline] (1.22 s) : 0, 1219665
Total [baseline] (10.737 s) : 0, 10736677
Agent [candidate] (1.221 s) : 0, 1220749
Total [candidate] (10.787 s) : 0, 10786546
section iast
Agent [baseline] (1.178 s) : 0, 1177923
Total [baseline] (10.878 s) : 0, 10878330
Agent [candidate] (1.187 s) : 0, 1186734
Total [candidate] (10.929 s) : 0, 10928950
section profiling
Agent [baseline] (1.195 s) : 0, 1194802
Total [baseline] (10.886 s) : 0, 10886313
Agent [candidate] (1.194 s) : 0, 1194475
Total [candidate] (10.906 s) : 0, 10905563

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	appsec	1.22 s	176.883 ms (17.0%)
Agent	iast	1.178 s	135.142 ms (13.0%)
Agent	profiling	1.195 s	152.02 ms (14.6%)
Total	tracing	10.718 s	-
Total	appsec	10.737 s	18.797 ms (0.2%)
Total	iast	10.878 s	160.45 ms (1.5%)
Total	profiling	10.886 s	168.433 ms (1.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	appsec	1.221 s	172.739 ms (16.5%)
Agent	iast	1.187 s	138.724 ms (13.2%)
Agent	profiling	1.194 s	146.465 ms (14.0%)
Total	tracing	10.745 s	-
Total	appsec	10.787 s	41.139 ms (0.4%)
Total	iast	10.929 s	183.542 ms (1.7%)
Total	profiling	10.906 s	160.156 ms (1.5%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~364cab503d, baseline=1.53.0-SNAPSHOT~f15598ae39

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.422 ms) : 0, 1422
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (730.913 ms) : 0, 730913
BytebuddyAgent [candidate] (732.686 ms) : 0, 732686
GlobalTracer [baseline] (241.47 ms) : 0, 241470
GlobalTracer [candidate] (242.596 ms) : 0, 242596
AppSec [baseline] (30.018 ms) : 0, 30018
AppSec [candidate] (30.242 ms) : 0, 30242
Debugger [baseline] (6.018 ms) : 0, 6018
Debugger [candidate] (6.001 ms) : 0, 6001
Remote Config [baseline] (638.271 µs) : 0, 638
Remote Config [candidate] (645.028 µs) : 0, 645
Telemetry [baseline] (11.361 ms) : 0, 11361
Telemetry [candidate] (13.42 ms) : 0, 13420
section appsec
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (753.066 ms) : 0, 753066
BytebuddyAgent [candidate] (753.785 ms) : 0, 753785
GlobalTracer [baseline] (235.097 ms) : 0, 235097
GlobalTracer [candidate] (235.173 ms) : 0, 235173
AppSec [baseline] (167.911 ms) : 0, 167911
AppSec [candidate] (167.298 ms) : 0, 167298
Debugger [baseline] (7.302 ms) : 0, 7302
Debugger [candidate] (8.735 ms) : 0, 8735
Remote Config [baseline] (623.154 µs) : 0, 623
Remote Config [candidate] (628.713 µs) : 0, 629
Telemetry [baseline] (9.813 ms) : 0, 9813
Telemetry [candidate] (9.204 ms) : 0, 9204
IAST [baseline] (23.479 ms) : 0, 23479
IAST [candidate] (23.429 ms) : 0, 23429
section iast
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (850.545 ms) : 0, 850545
BytebuddyAgent [candidate] (857.551 ms) : 0, 857551
GlobalTracer [baseline] (232.81 ms) : 0, 232810
GlobalTracer [candidate] (234.104 ms) : 0, 234104
AppSec [baseline] (26.509 ms) : 0, 26509
AppSec [candidate] (28.475 ms) : 0, 28475
Debugger [baseline] (6.6 ms) : 0, 6600
Debugger [candidate] (8.126 ms) : 0, 8126
Remote Config [baseline] (583.994 µs) : 0, 584
Remote Config [candidate] (577.37 µs) : 0, 577
Telemetry [baseline] (8.364 ms) : 0, 8364
Telemetry [candidate] (8.336 ms) : 0, 8336
IAST [baseline] (30.0 ms) : 0, 30000
IAST [candidate] (27.043 ms) : 0, 27043
section profiling
ProfilingAgent [baseline] (108.923 ms) : 0, 108923
ProfilingAgent [candidate] (108.924 ms) : 0, 108924
crashtracking [baseline] (1.399 ms) : 0, 1399
crashtracking [candidate] (1.394 ms) : 0, 1394
BytebuddyAgent [baseline] (761.015 ms) : 0, 761015
BytebuddyAgent [candidate] (761.417 ms) : 0, 761417
GlobalTracer [baseline] (221.865 ms) : 0, 221865
GlobalTracer [candidate] (222.057 ms) : 0, 222057
AppSec [baseline] (30.017 ms) : 0, 30017
AppSec [candidate] (29.998 ms) : 0, 29998
Debugger [baseline] (6.301 ms) : 0, 6301
Debugger [candidate] (6.241 ms) : 0, 6241
Remote Config [baseline] (687.212 µs) : 0, 687
Remote Config [candidate] (698.762 µs) : 0, 699
Telemetry [baseline] (15.27 ms) : 0, 15270
Telemetry [candidate] (14.385 ms) : 0, 14385
Profiling [baseline] (109.549 ms) : 0, 109549
Profiling [candidate] (109.585 ms) : 0, 109585

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context
git_commit_date	1755272433	1755367363
git_commit_sha	`f15598a`	`364cab5`
release_version	1.53.0-SNAPSHOT~f15598ae39	1.53.0-SNAPSHOT~364cab503d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755368860	1755368860
ci_job_id	1083318938	1083318938
ci_pipeline_id	73877290	73877290
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-vwydygnx 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-vwydygnx 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:iast:high_load	better [-2.054ms; -1.194ms] or [-4.458%; -2.590%]	unstable [-3.941op/s; +11.266op/s] or [-3.880%; +11.092%]	44.455ms	105.225op/s	46.079ms	101.562op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~364cab503d, baseline=1.53.0-SNAPSHOT~f15598ae39
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.115 ms) : 36811, 37419
.   : milestone, 37115,
appsec (48.902 ms) : 48478, 49327
.   : milestone, 48902,
code_origins (45.262 ms) : 44891, 45633
.   : milestone, 45262,
iast (46.079 ms) : 45671, 46486
.   : milestone, 46079,
profiling (47.761 ms) : 47322, 48199
.   : milestone, 47761,
tracing (44.247 ms) : 43869, 44626
.   : milestone, 44247,
section candidate
no_agent (36.339 ms) : 36054, 36625
.   : milestone, 36339,
appsec (48.359 ms) : 47916, 48802
.   : milestone, 48359,
code_origins (45.286 ms) : 44902, 45670
.   : milestone, 45286,
iast (44.455 ms) : 44063, 44847
.   : milestone, 44455,
profiling (47.399 ms) : 46968, 47831
.   : milestone, 47399,
tracing (44.56 ms) : 44176, 44944
.   : milestone, 44560,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.115 ms [36.811 ms, 37.419 ms]	-
appsec	48.902 ms [48.478 ms, 49.327 ms]	11.788 ms (31.8%)
code_origins	45.262 ms [44.891 ms, 45.633 ms]	8.147 ms (22.0%)
iast	46.079 ms [45.671 ms, 46.486 ms]	8.964 ms (24.2%)
profiling	47.761 ms [47.322 ms, 48.199 ms]	10.646 ms (28.7%)
tracing	44.247 ms [43.869 ms, 44.626 ms]	7.133 ms (19.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.339 ms [36.054 ms, 36.625 ms]	-
appsec	48.359 ms [47.916 ms, 48.802 ms]	12.019 ms (33.1%)
code_origins	45.286 ms [44.902 ms, 45.67 ms]	8.947 ms (24.6%)
iast	44.455 ms [44.063 ms, 44.847 ms]	8.115 ms (22.3%)
profiling	47.399 ms [46.968 ms, 47.831 ms]	11.06 ms (30.4%)
tracing	44.56 ms [44.176 ms, 44.944 ms]	8.221 ms (22.6%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~364cab503d, baseline=1.53.0-SNAPSHOT~f15598ae39
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.298 ms) : 4250, 4346
.   : milestone, 4298,
iast (9.332 ms) : 9182, 9483
.   : milestone, 9332,
iast_FULL (14.079 ms) : 13796, 14362
.   : milestone, 14079,
iast_GLOBAL (10.341 ms) : 10163, 10518
.   : milestone, 10341,
profiling (8.602 ms) : 8470, 8735
.   : milestone, 8602,
tracing (7.629 ms) : 7517, 7741
.   : milestone, 7629,
section candidate
no_agent (4.319 ms) : 4269, 4369
.   : milestone, 4319,
iast (9.531 ms) : 9366, 9696
.   : milestone, 9531,
iast_FULL (14.521 ms) : 14233, 14810
.   : milestone, 14521,
iast_GLOBAL (10.086 ms) : 9899, 10274
.   : milestone, 10086,
profiling (8.654 ms) : 8514, 8794
.   : milestone, 8654,
tracing (7.403 ms) : 7298, 7509
.   : milestone, 7403,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.298 ms [4.25 ms, 4.346 ms]	-
iast	9.332 ms [9.182 ms, 9.483 ms]	5.034 ms (117.1%)
iast_FULL	14.079 ms [13.796 ms, 14.362 ms]	9.781 ms (227.6%)
iast_GLOBAL	10.341 ms [10.163 ms, 10.518 ms]	6.042 ms (140.6%)
profiling	8.602 ms [8.47 ms, 8.735 ms]	4.304 ms (100.1%)
tracing	7.629 ms [7.517 ms, 7.741 ms]	3.331 ms (77.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.319 ms [4.269 ms, 4.369 ms]	-
iast	9.531 ms [9.366 ms, 9.696 ms]	5.212 ms (120.7%)
iast_FULL	14.521 ms [14.233 ms, 14.81 ms]	10.203 ms (236.2%)
iast_GLOBAL	10.086 ms [9.899 ms, 10.274 ms]	5.768 ms (133.6%)
profiling	8.654 ms [8.514 ms, 8.794 ms]	4.335 ms (100.4%)
tracing	7.403 ms [7.298 ms, 7.509 ms]	3.084 ms (71.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context
git_commit_date	1755272433	1755367363
git_commit_sha	`f15598a`	`364cab5`
release_version	1.53.0-SNAPSHOT~f15598ae39	1.53.0-SNAPSHOT~364cab503d

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1755369356	1755369356
ci_job_id	1083318939	1083318939
ci_pipeline_id	73877290	73877290
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-myz26kuz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-myz26kuz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~364cab503d, baseline=1.53.0-SNAPSHOT~f15598ae39
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.635 s) : 15635000, 15635000
.   : milestone, 15635000,
appsec (14.879 s) : 14879000, 14879000
.   : milestone, 14879000,
iast (18.279 s) : 18279000, 18279000
.   : milestone, 18279000,
iast_GLOBAL (18.276 s) : 18276000, 18276000
.   : milestone, 18276000,
profiling (15.487 s) : 15487000, 15487000
.   : milestone, 15487000,
tracing (15.113 s) : 15113000, 15113000
.   : milestone, 15113000,
section candidate
no_agent (15.278 s) : 15278000, 15278000
.   : milestone, 15278000,
appsec (14.968 s) : 14968000, 14968000
.   : milestone, 14968000,
iast (18.187 s) : 18187000, 18187000
.   : milestone, 18187000,
iast_GLOBAL (17.875 s) : 17875000, 17875000
.   : milestone, 17875000,
profiling (15.556 s) : 15556000, 15556000
.   : milestone, 15556000,
tracing (15.078 s) : 15078000, 15078000
.   : milestone, 15078000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.635 s [15.635 s, 15.635 s]	-
appsec	14.879 s [14.879 s, 14.879 s]	-756.0 ms (-4.8%)
iast	18.279 s [18.279 s, 18.279 s]	2.644 s (16.9%)
iast_GLOBAL	18.276 s [18.276 s, 18.276 s]	2.641 s (16.9%)
profiling	15.487 s [15.487 s, 15.487 s]	-148.0 ms (-0.9%)
tracing	15.113 s [15.113 s, 15.113 s]	-522.0 ms (-3.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.278 s [15.278 s, 15.278 s]	-
appsec	14.968 s [14.968 s, 14.968 s]	-310.0 ms (-2.0%)
iast	18.187 s [18.187 s, 18.187 s]	2.909 s (19.0%)
iast_GLOBAL	17.875 s [17.875 s, 17.875 s]	2.597 s (17.0%)
profiling	15.556 s [15.556 s, 15.556 s]	278.0 ms (1.8%)
tracing	15.078 s [15.078 s, 15.078 s]	-200.0 ms (-1.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~364cab503d, baseline=1.53.0-SNAPSHOT~f15598ae39
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.401 ms) : 2351, 2451
.   : milestone, 2401,
iast (2.197 ms) : 2134, 2260
.   : milestone, 2197,
iast_GLOBAL (2.234 ms) : 2171, 2297
.   : milestone, 2234,
profiling (2.04 ms) : 1990, 2091
.   : milestone, 2040,
tracing (2.017 ms) : 1968, 2067
.   : milestone, 2017,
section candidate
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (3.651 ms) : 3433, 3869
.   : milestone, 3651,
iast (2.193 ms) : 2130, 2255
.   : milestone, 2193,
iast_GLOBAL (2.234 ms) : 2170, 2297
.   : milestone, 2234,
profiling (2.48 ms) : 2312, 2647
.   : milestone, 2480,
tracing (2.023 ms) : 1974, 2073
.   : milestone, 2023,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.461 ms, 1.484 ms]	-
appsec	2.401 ms [2.351 ms, 2.451 ms]	928.558 µs (63.1%)
iast	2.197 ms [2.134 ms, 2.26 ms]	724.498 µs (49.2%)
iast_GLOBAL	2.234 ms [2.171 ms, 2.297 ms]	761.406 µs (51.7%)
profiling	2.04 ms [1.99 ms, 2.091 ms]	568.092 µs (38.6%)
tracing	2.017 ms [1.968 ms, 2.067 ms]	544.898 µs (37.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.46 ms, 1.483 ms]	-
appsec	3.651 ms [3.433 ms, 3.869 ms]	2.18 ms (148.2%)
iast	2.193 ms [2.13 ms, 2.255 ms]	721.512 µs (49.0%)
iast_GLOBAL	2.234 ms [2.17 ms, 2.297 ms]	762.507 µs (51.8%)
profiling	2.48 ms [2.312 ms, 2.647 ms]	1.009 ms (68.6%)
tracing	2.023 ms [1.974 ms, 2.073 ms]	552.079 µs (37.5%)

smola

I did an overall review, particularly focusing on the AppSec instrumentations, looks good to me.

smola · 2025-08-13T09:08:17Z

...umentation/axway-api/src/main/java/datadog/trace/instrumentation/axway/HTTPPluginAdvice.java

 import net.bytebuddy.asm.Advice;

 public class HTTPPluginAdvice {

  @Advice.OnMethodEnter(suppress = Throwable.class)
  public static AgentScope onEnter(@Advice.Argument(value = 2) final Object serverTransaction) {
-    final AgentSpan span = startSpan(DECORATE.spanName()).setMeasured(true);
+    final AgentSpan span = startSpan("axway-api", DECORATE.spanName()).setMeasured(true);


I didn't verify axway-api is the correct integration name just based on the diff, but worth a double check.

Yes it is:

dd-trace-java/dd-java-agent/instrumentation/axway-api/src/main/java/datadog/trace/instrumentation/axway/AxwayHTTPPluginInstrumentation.java

Line 18 in e8df8a0

super("axway-api");

Not sure why I fixed this call in particular 🤷 Found a warning while reading the code and can't help myself 😅 But it's more to the IDM team to fix it.

...rtx-web-3.4/src/main/java/datadog/trace/instrumentation/vertx_3_4/server/VertxDecorator.java

feat(bootstrap): Migrate Spray instrumentation to Context API

dc9d144

PerfectSlayer added the tag: do not merge Do not merge changes label Aug 13, 2025

PerfectSlayer added 2 commits August 13, 2025 09:47

feat(bootstrap): Migrate Tomcat instrumentation to Context API

a5d200d

feat(bootstrap): Migrate Liberty instrumentations to Context API

9994ab4

feat(bootstrap): Migrate instrumentations to Context API

c82297c

PerfectSlayer added type: refactoring comp: context propagation Trace context propagation and removed tag: do not merge Do not merge changes labels Aug 13, 2025

PerfectSlayer marked this pull request as ready for review August 13, 2025 09:00

PerfectSlayer requested review from a team as code owners August 13, 2025 09:00

PerfectSlayer requested a review from smola August 13, 2025 09:00

smola requested review from a team, jandro996, ygree and smola and removed request for smola and a team August 13, 2025 09:00

smola approved these changes Aug 13, 2025

View reviewed changes

PerfectSlayer mentioned this pull request Aug 13, 2025

Improve Instrumenter API to use Context instead of Span #9211

Merged

PerfectSlayer added 2 commits August 13, 2025 12:24

fix(bootstrap): Fix unexpected call to IG callback

a565097

feat(play): Simplify testing

f3a982f

AlexeyKuznetsov-DD approved these changes Aug 13, 2025

View reviewed changes

sarahchen6 reviewed Aug 13, 2025

View reviewed changes

...rtx-web-3.4/src/main/java/datadog/trace/instrumentation/vertx_3_4/server/VertxDecorator.java Outdated Show resolved Hide resolved

sarahchen6 approved these changes Aug 13, 2025

View reviewed changes

PerfectSlayer mentioned this pull request Aug 14, 2025

[Java] Fix exception replay snapshots DataDog/system-tests#5066

Merged

6 tasks

fix(bootstrap): Fix import

9f10e63

chore: Upgrade system tests

c23bbe5

PerfectSlayer requested a review from a team as a code owner August 14, 2025 09:11

PerfectSlayer requested review from bric3 and removed request for a team August 14, 2025 09:11

mhlidd mentioned this pull request Aug 14, 2025

[Java] Disabling Debugger Tests DataDog/system-tests#5072

Merged

6 tasks

Merge branch 'master' into bbujon/context

364cab5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate instrumentations to Context API #9358

Migrate instrumentations to Context API #9358

PerfectSlayer commented Aug 13, 2025 •

edited by jira bot

Loading

Uh oh!

datadog-official bot commented Aug 13, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

Uh oh!

pr-commenter bot commented Aug 13, 2025 •

edited

Loading

Uh oh!

smola left a comment

Uh oh!

smola Aug 13, 2025

Uh oh!

PerfectSlayer Aug 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Migrate instrumentations to Context API #9358

Are you sure you want to change the base?

Migrate instrumentations to Context API #9358

Conversation

PerfectSlayer commented Aug 13, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Aug 13, 2025 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

smola left a comment

Choose a reason for hiding this comment

Uh oh!

smola Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PerfectSlayer commented Aug 13, 2025 •

edited by jira bot

Loading

datadog-official bot commented Aug 13, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

pr-commenter bot commented Aug 13, 2025 •

edited

Loading

PerfectSlayer Aug 13, 2025 •

edited

Loading